[lldb-dap] Fix machine-overridable scope #137723
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
My previous commit was a bit sloppy, I didn't spot that `lldb-dap.executable-path` already had a scope and I didn't consider that `lldb-dap.log-path` should have the same scope. This PR addresses both: - Fix duplicate scope for `lldb-dap.executable-path`. - Change scope of `lldb-dap.log-path` to `machine-overridable` too.
Member
|
@llvm/pr-subscribers-lldb Author: Jonas Devlieghere (JDevlieghere) ChangesMy previous commit was a bit sloppy, I didn't spot that This PR addresses both:
Full diff: https://github.com/llvm/llvm-project/pull/137723.diff 1 Files Affected:
diff --git a/lldb/tools/lldb-dap/package.json b/lldb/tools/lldb-dap/package.json
index adbb5b2bcf722..5cfd79849b17f 100644
--- a/lldb/tools/lldb-dap/package.json
+++ b/lldb/tools/lldb-dap/package.json
@@ -73,9 +73,8 @@
"title": "lldb-dap",
"properties": {
"lldb-dap.executable-path": {
- "scope": "resource",
- "type": "string",
"scope": "machine-overridable",
+ "type": "string",
"description": "The path to the lldb-dap binary, e.g. /usr/local/bin/lldb-dap"
},
"lldb-dap.arguments": {
@@ -88,7 +87,7 @@
"description": "The list of additional arguments used to launch the debug adapter executable."
},
"lldb-dap.log-path": {
- "scope": "resource",
+ "scope": "machine-overridable",
"type": "string",
"description": "The log path for lldb-dap (if any)"
},
|
ashgti
approved these changes
Apr 28, 2025
IanWood1
pushed a commit
to IanWood1/llvm-project
that referenced
this pull request
May 6, 2025
My previous commit was a bit sloppy, I didn't spot that `lldb-dap.executable-path` already had a scope and I didn't consider that `lldb-dap.log-path` should have the same scope. This PR addresses both: - Fix duplicate scope for `lldb-dap.executable-path`. - Change scope of `lldb-dap.log-path` to `machine-overridable` too.
GeorgeARM
pushed a commit
to GeorgeARM/llvm-project
that referenced
this pull request
May 7, 2025
My previous commit was a bit sloppy, I didn't spot that `lldb-dap.executable-path` already had a scope and I didn't consider that `lldb-dap.log-path` should have the same scope. This PR addresses both: - Fix duplicate scope for `lldb-dap.executable-path`. - Change scope of `lldb-dap.log-path` to `machine-overridable` too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My previous commit was a bit sloppy, I didn't spot that
lldb-dap.executable-pathalready had a scope and I didn't consider thatlldb-dap.log-pathshould have the same scope.This PR addresses both:
lldb-dap.executable-path.lldb-dap.log-pathtomachine-overridabletoo.